Skip to content

Conversation

@carlobeltrame
Copy link
Member

@carlobeltrame carlobeltrame commented May 22, 2025

Also sets the period selection dropdown to readonly, with appropriate style (hide the caret).

Screenshot_20250522-140939_Firefox (1).jpg

This has a small risk of some users still having print configs in their local storage with some empty period selection. However, our prints can handle this, and the users can easily fix their print config themselves if needed. Fixed

Todo:

  • When auto-repairing a config, make sure to also select the sole period

@carlobeltrame carlobeltrame force-pushed the auto-select-sole-period branch from b2c898c to 8f7689c Compare May 22, 2025 09:32
@carlobeltrame carlobeltrame added the deploy! Creates a feature branch deployment for this PR label May 22, 2025
@github-actions
Copy link

github-actions bot commented May 22, 2025

Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

@carlobeltrame carlobeltrame force-pushed the auto-select-sole-period branch from 8f7689c to ec513d7 Compare May 24, 2025 18:47
@BacLuc BacLuc requested a review from a team May 24, 2025 19:29
@BacLuc
Copy link
Contributor

BacLuc commented May 24, 2025

Minor inconvenience:
If you delete the period that was saved in the print config, the print configurator does not like it:

image
But if you reset it, it works again.

@carlobeltrame
Copy link
Member Author

Minor inconvenience: If you delete the period that was saved in the print config, the print configurator does not lake it

Should be fixed in a090765

@pmattmann pmattmann added this pull request to the merge queue Jun 5, 2025
Merged via the queue into ecamp:devel with commit c2bd8e2 Jun 5, 2025
30 checks passed
@carlobeltrame carlobeltrame deleted the auto-select-sole-period branch June 10, 2025 18:13
@carlobeltrame carlobeltrame mentioned this pull request Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deploy! Creates a feature branch deployment for this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants