Skip to content

deployment-pr-cleanup.yml: delete env if feature branch deployment is deleted #7001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2025
Merged

deployment-pr-cleanup.yml: delete env if feature branch deployment is deleted #7001

merged 1 commit into from
Mar 11, 2025

Conversation

@BacLuc
Copy link
Contributor

@BacLuc BacLuc commented Mar 8, 2025

That we don't have so many environments we don't need.

@BacLuc
deployment-pr-cleanup.yml: delete env if feature branch deployment is…
754db4c 
… deleted

That we don't have so many environments we don't need.
@BacLuc BacLuc added the deploy! Creates a feature branch deployment for this PR label Mar 8, 2025
@BacLuc BacLuc temporarily deployed to feature-branch March 8, 2025 20:30 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Mar 8, 2025 •
edited
Loading

⛔ Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

@BacLuc BacLuc removed the deploy! Creates a feature branch deployment for this PR label Mar 8, 2025
@BacLuc BacLuc requested a review from a team March 8, 2025 20:35
manuelmeister
manuelmeister approved these changes Mar 8, 2025
View reviewed changes
Copy link
Member

@manuelmeister manuelmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was it deactivated instead of deleted?

@BacLuc BacLuc requested a review from a team March 9, 2025 08:01
@BacLuc
Copy link
Contributor Author

BacLuc commented Mar 9, 2025

Why was it deactivated instead of deleted?

I don't know

carlobeltrame
carlobeltrame approved these changes Mar 11, 2025
View reviewed changes
Copy link
Member

@carlobeltrame carlobeltrame left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because deleting wasn't available back when we originally implemented the feature branch deployments: https://github.com/bobheadxi/deployments/tree/v0.6.2

@BacLuc BacLuc added this pull request to the merge queue Mar 11, 2025
@carlobeltrame
Copy link
Member

Did you see the notice about the required permissions for the service token? Do we already have this in place?
https://github.com/bobheadxi/deployments/tree/main?tab=readme-ov-file#step-delete-env

Merged via the queue into devel with commit 0a0d57d Mar 11, 2025
60 of 62 checks passed
@BacLuc BacLuc deleted the delete-envs-on-cleanup branch March 11, 2025 08:56
@BacLuc
Copy link
Contributor Author

BacLuc commented Mar 11, 2025

Did you see the notice about the required permissions for the service token? Do we already have this in place?
https://github.com/bobheadxi/deployments/tree/main?tab=readme-ov-file#step-delete-env

It seems Like.
Or do you See the env for the feature branch deployment of this branch ;)

@carlobeltrame carlobeltrame mentioned this pull request Jun 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manuelmeister manuelmeister manuelmeister approved these changes

@carlobeltrame carlobeltrame carlobeltrame approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BacLuc @carlobeltrame @manuelmeister