Performance improvements #6956
Performance improvements #6956
Conversation
manuelmeister
force-pushed
the
bugfix/embed-user-in-profile
branch
from
3c6856e to
bc2b895
Compare
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
BacLuc
left a comment
BacLuc
left a comment
There was a problem hiding this comment.
The camp list ist very fast on the feature branch deployment, thank you.
You skipped the api tests on the last check run https://github.com/ecamp/ecamp3/actions/runs/13631749025/job/38100877583?pr=6956
because it already ran a day before.
Answer the questions, and i think we are good to go.
| description: |- | ||
| A person using eCamp. | ||
| The properties available for all other eCamp users are here. | ||
| description: '' |
There was a problem hiding this comment.
Why did we loose the description here?
There was a problem hiding this comment.
No clue, just ran update-snapshots
There was a problem hiding this comment.
I would say create an issue, i would rather have the performance improvements.
But we should readd the description later.
...pi/SnapshotTests/__snapshots__/ResponseSnapshotTest__testRootEndpointMatchesSnapshot__1.json
Show resolved
Hide resolved
| this.isAdmin = isAdmin() | ||
| setTimeout(() => { | ||
| this.deferredLoad = false | ||
| }, 400) |
There was a problem hiding this comment.
why 400?
wouldn't it be better to enqueue this as the last of the promises?
just use a data field for the invitationcount, and fill it in mounted?
There was a problem hiding this comment.
Just some arbitrary late value. We don't habe a global last promise.
BacLuc
added
the
test-flaky-e2e!
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
They changed in ecamp#6956 And that they don't change in an unrelated pr, i changed a value in all snapshots, and here are the ones were the order of the properties changed.
3 participants
First load api endpoint, then directly load profile (with embedded user)