api: rename parameter $object to $data for Normalizer #6443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BacLuc
commented
Nov 30, 2024
| private EntityManagerInterface|MockObject $entityManager; | ||
|
|
||
| private ?FilterInterface $filterInstance; | ||
| private null|DateFilter|SearchFilterInterface $filterInstance; |
There was a problem hiding this comment.
This test failed locally because the filters are not under a common interface anymore...?
This fixes the psalm error - Argument 1 of App\Serializer\Normalizer\CircularReferenceDetectingHalItemNormalizer::normalize has wrong name $object, expecting $data as defined by Symfony\Component\Serializer\Normalizer\NormalizerInterface::normalize (see https://psalm.dev/230) public function normalize($object, $format = null, array $context = []): null|array|\ArrayObject|bool|float|int|string { } After 6bdbd2e. Suppress the error for CircularReferenceDetectingHalItemNormalizer::normalize, because AbstractItemNormalizer of api-platform and AbstractObjectNormalizer of Symfony are not there yet.
carlobeltrame
approved these changes
Dec 1, 2024
pmattmann
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the psalm error