-
Notifications
You must be signed in to change notification settings - Fork 62
dashboard add scroll-to-today #6145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dashboard add scroll-to-today #6145
Conversation
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| :aria-labelledby="dayUri + 'th'" | ||
| > | ||
| <tr class="day-header__row"> | ||
| <tr :ref="days[dayUri].id" class="day-header__row"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be set on the tbody and preferably as an id. Which we could reflect in the url.
Then the tbody should have a scroll-margin-top with the same value as the top of the .day-header: So the navbar does not cover the content:
If solved as an id, someone could then share this link and it will automatically go to the same day.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree to comment of @manuelmeister.
As this button/icon is really only visible during the actual camp, I would be ok with an action button with actual text (for example: "go to today" or shorter "today")
Also for me the scrolling action is always a bit too far (day header is not shown anymore), both on mobile and on desktop. I think this could be fine-tuned either with the block option or with scroll-margin-top css.
Code looks good to me.
b1024c2 to
8059636
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice changes. I think I will eventually create an improved hover button solution. But this change already improves the UX.


related to #5608
Not a auto-scroll
But a link to scroll to 'today'
To test: