Skip to content

Conversation

@BacLuc
Copy link
Contributor

@BacLuc BacLuc commented Oct 8, 2024

This allows the web socket connection to the vite server(s) for hot reloading again.
I also added this for the other upstreams, that they can also use websockets if they wish in the future.
See https://nginx.org/en/docs/http/websocket.html for the docs. Don't overwrite the http version...if the client comes with a too low http version, he will anyway not be able to use websockets.

This allows the web socket connection to the vite server(s) for hot reloading
again.
I also added this for the other upstreams, that they can also use
websockets if they wish in the future.
See https://nginx.org/en/docs/http/websocket.html for the docs.
Don't overwrite the http version...if the client comes with a too low
http version, he will anyway not be able to use websockets.
@BacLuc BacLuc requested a review from a team October 8, 2024 20:49
Copy link
Member

@manuelmeister manuelmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@manuelmeister manuelmeister added this pull request to the merge queue Oct 15, 2024
Merged via the queue into ecamp:devel with commit 5f82d7d Oct 15, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants