feat(print): activity list for courses #6031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmattmann
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
pmattmann
approved these changes
Sep 29, 2024
BacLuc
approved these changes
Sep 29, 2024
| design: { | ||
| multiple: true, | ||
| }, | ||
| repairConfig(config, camp) { |
There was a problem hiding this comment.
Here some tests would be good
| <div class="tw-font-bold">{{ entry.checklist.name }}</div> | ||
| <ul class="tw-list-disc tw-list-inside"> | ||
| <li v-for="item in entry.items" :key="item.id"> | ||
| <span class="tw-mr-1">{{ item.number }}</span> {{ item.text }} |
There was a problem hiding this comment.
It would be good if the text would only wrap to the start of the text.
and maybe we don't need the list style (and just use the numbering, without the dot at the start)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
All is only implemented in nuxt print. React print would need a separate implementation.
Normal program print
Dedicated activity overview print for courses