Skip to content

Checklist: add pbs-checklist (basis, aufbau, wolf, pfadi) #6015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 28, 2024
Merged

Checklist: add pbs-checklist (basis, aufbau, wolf, pfadi) #6015

merged 3 commits into from
Sep 28, 2024

Conversation

@pmattmann
Copy link
Member

PBS-Checklist für

  • Basis Wolf
  • Basis Pfadi
  • Aufbau Wolf
  • Aufbau Pfadi

@pmattmann pmattmann requested a review from a team September 28, 2024 09:23
@pmattmann pmattmann mentioned this pull request Sep 28, 2024
Closed
BacLuc
BacLuc reviewed Sep 28, 2024
View reviewed changes
Copy link
Contributor

@BacLuc BacLuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sieht gut aus, hab gemini hat noch kleine fehler gefunden

usu
usu reviewed Sep 28, 2024
View reviewed changes
Copy link
Member

@usu usu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • It would be the first time we introduce sequential IDs. Any potential issue with that?
  • Should we also update migrations/prod/data.sql? Not sure what the latest decision/discussion was on this for similar migrations.

@pmattmann pmattmann requested a review from BacLuc September 28, 2024 11:53
@pmattmann
Copy link
Member Author

pmattmann commented Sep 28, 2024 •
edited by manuelmeister
Loading

  • It would be the first time we introduce sequential IDs. Any potential issue with that?

I don't think so.

  • Should we also update migrations/prod/data.sql? Not sure what the latest decision/discussion was on this for similar migrations.

It is actually user data. Therefore not 'seed'. Not really migration either.
But as long as we do not have a backend for external parties (PBS, Jubla), they can at least provide sql-files.

@pmattmann pmattmann added this pull request to the merge queue Sep 28, 2024
Merged via the queue into ecamp:devel with commit c6cd7d8 Sep 28, 2024
34 checks passed
@pmattmann pmattmann deleted the feature/insert-prototype-checklist branch September 28, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@usu usu usu approved these changes

@BacLuc BacLuc BacLuc approved these changes

@manuelmeister manuelmeister manuelmeister approved these changes

@simfeld simfeld simfeld approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pmattmann @usu @BacLuc @manuelmeister @simfeld