replace uri-js with uri-js-replace #5846
Merged
+32
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmattmann
approved these changes
Sep 12, 2024
simfeld
approved these changes
Sep 12, 2024
That we have less dependencies on punycode. uri-js is not maintained anymore, thus we won't get an update. uri-js-replace removed the dependency on punycode. This starts to solve the deprecation warning: "punycode is deprecated, use a userland alternative instead." Issue: ecamp#5843 Can be reverted as soon as the dependencies don't depend on uri-js anymore.
BacLuc
force-pushed
the
replace-uri-js
branch
from
fbc35ac to
54f2969
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That we have less dependencies on punycode.
uri-js is not maintained anymore, thus we won't get an update. uri-js-replace removed the dependency on punycode.
This starts to solve the deprecation warning:
"punycode is deprecated, use a userland alternative instead."
Issue: #5843
Can be reverted as soon as the dependencies don't depend on uri-js anymore.