👷 Add PR preview to CI #90
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benjamin-Piper
force-pushed
the
pr-preview-ci
branch
from
6767623 to
187c428
Compare
I initially wanted to separate this out into separate workflows. I learned, however, that workflows and jobs are isolated and don't share state. I thought it would be simplest (although perhaps very janky) to have this all in one job in one workflow and use conditions to control the CI flow. I'm not too sure how the concurrency group works, but it was recommended as a [best practice](https://github.com/rossjrw/pr-preview-action?tab=readme-ov-file#set-a-concurrency-group). I also started using a GitHub action for deploying to GitHub pages as I moved from force-pushing to rebasing and the latter was getting tricky for me. I did this because PR previews work by adding a folder on gh-pages, so force-pushing would overwrite this and we'd lose our previews all the time.
Benjamin-Piper
force-pushed
the
pr-preview-ci
branch
from
187c428 to
c4471ac
Compare
|
Aha. I forgot to read the README of the PR preview action:
Closing for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I initially wanted to separate this out into separate workflows. I learned, however, that workflows and jobs are isolated and don't share state.
I thought it would be simplest (although perhaps very janky) to have this all in one job in one workflow and use conditions to control the CI flow.
I'm not too sure how the concurrency group works, but it was recommended as a best practice.
I also started using a GitHub action for deploying to GitHub pages as I moved from force-pushing to rebasing and the latter was getting tricky for me.
I did this because PR previews work by adding a folder on gh-pages, so force-pushing would overwrite this and we'd lose our previews all the time.