New total_chunks_storage function
#841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpiannucci
approved these changes
Mar 17, 2025
Contributor
mpiannucci
left a comment
mpiannucci
left a comment
There was a problem hiding this comment.
Approved with one question
| while let Some(snap_id) = all_snaps.try_next().await? { | ||
| let snap = asset_manager.fetch_snapshot(&snap_id).await?; | ||
|
|
||
| for manifest_id in snap.manifest_files().map(|mf| mf.id) { |
Contributor
There was a problem hiding this comment.
Is it worth extracting this to be able to get the size of a specific snapshot? Or is that not quite relevant. Wondering if it could be helpful for deciding when to gc
Collaborator
Author
There was a problem hiding this comment.
Yeah, that would be useful, but I don't have an immediate use case. I can add it a bit down the road if that's OK
paraseba
force-pushed
the
push-zyzxwqpvlqwk
branch
from
89ce4cf to
f0c5665
Compare
This new method in the `Repository` class computes the total space used by chunks in all snapshots. Only native, pointed chunks are included. Closes: #836
paraseba
force-pushed
the
push-zyzxwqpvlqwk
branch
from
f0c5665 to
0a31293
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new method in the
Repositoryclass computes the total space used by chunks in all snapshots. Only native, pointed chunks are included.Closes: #836