Implement expiration of snapshots #636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Some tasks that will come in future PRs:
|
paraseba
force-pushed
the
push-xovytstkowxw
branch
from
66383b1 to
00db21c
Compare
mpiannucci
approved these changes
Jan 28, 2025
| } | ||
|
|
||
| /// Cretase a new `Snapshot` with all the same data as `self` but a different parent | ||
| pub fn adopt(&self, parent: &Snapshot) -> Self { |
| /// ancestry. Any other snapshots are not touched. | ||
| /// | ||
| /// The operation will edit in place the oldest non-expired snapshot, | ||
| /// changing its parent to be the root of the repo. |
Contributor
There was a problem hiding this comment.
This means the initial commit snapshot is always the parent right?
Collaborator
Author
There was a problem hiding this comment.
Exactly, yes, the root of the repo will become the new parent of the first non-expired snapshot
Contributor
|
This is so cool and really easy to read |
paraseba
force-pushed
the
push-xnwysvupwxyz
branch
from
d2a8f4a to
d0279d3
Compare
paraseba
force-pushed
the
push-xovytstkowxw
branch
from
00db21c to
84101d5
Compare
Also fix a bug where we were listing deleted tags. Some minimal refactoring too.
paraseba
force-pushed
the
push-xovytstkowxw
branch
from
84101d5 to
9986d59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix a bug where we were listing deleted tags.
Some minimal refactoring too.