Better defaulting mechanism for configuration #613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpiannucci
approved these changes
Jan 23, 2025
|
|
||
| assert ( | ||
| repr(config) | ||
| == r"RepositoryConfig(inline_chunk_threshold_bytes=5, unsafe_overwrite_refs=True, get_partial_values_concurrency=42, compression=CompressionConfig(algorithm=None, level=2), caching=CachingConfig(num_snapshot_nodes=None, num_chunk_refs=8, num_transaction_changes=None, num_bytes_attributes=None, num_bytes_chunks=None), storage=StorageSettings(concurrency=StorageConcurrencySettings(max_concurrent_requests_for_object=5, ideal_concurrent_request_size=1000000)))" |
Now configurations can be merged, this means users can pass only the
configuration parameters they want to override, not the full object.
With this, users don't have to fetch the configuration to be able to
open a repository with some config changes.
Example:
```rust
Repository::open(
...,
config=RepositoryConfig{inline_chunk_threshold_bytes=0, ..Default::default()})
```
Will override only `inline_chunk_threshold_bytes` and keep the rest of
the configuration as stored in the repo (or the default config if no
persistent configuration is found).
In addition, now we don't store the configuration for the repo on repo
creation, unless it's different from the default. This allows us to know
the user hasn't changed configuration, which will help with version
evolution.
To achieve all this:
* Now all configuration parameters across all structs are optional
* We introduce a `merge` function for configurations
paraseba
force-pushed
the
push-qyvkrxwskpts
branch
from
765d95e to
1108bd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now configurations can be merged, this means users can pass only the configuration parameters they want to override, not the full object. With this, users don't have to fetch the configuration to be able to open a repository with some config changes.
Example:
Will override only
inline_chunk_threshold_bytesand keep the rest of the configuration as stored in the repo (or the default config if no persistent configuration is found).In addition, now we don't store the configuration for the repo on repo creation, unless it's different from the default. This allows us to know the user hasn't changed configuration, which will help with version evolution.
To achieve all this:
mergefunction for configurations