Efficient getsize in the Zarr store #605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements a natie version of: ```python async def getsize(self, key: str) -> int: ... ``` Notably, it doesn't implement `getsize_prefix`. We think letting zarr-python do the loop that calls `getsize` can be enough performance.
Collaborator
Author
|
Codespell will approve once we merge my manifest open PR that has all these fixes |
dcherian
reviewed
Jan 22, 2025
| # wrap the async method in a sync method. | ||
| return self._store.list_dir(prefix) | ||
|
|
||
| async def getsize(self, key: str) -> int: |
Contributor
There was a problem hiding this comment.
there is a getsize_prefix too: https://zarr.readthedocs.io/en/stable/api/zarr/abc/store/index.html#zarr.abc.store.Store.getsize_prefix
Collaborator
Author
There was a problem hiding this comment.
yeah, see comment in the PR ... I want to try if we can skip implementing those. If performance is not there we can implement.
Contributor
There was a problem hiding this comment.
AH ok. I'll push a benchmark, then approve.
Contributor
|
Phew after some work: So big difference in No difference in |
dcherian
approved these changes
Jan 23, 2025
dcherian
reviewed
Jan 23, 2025
| # > pytest [...] --benchmark-save=main_3abfa48a --icechunk-prefix=benchmarks/main_3abfa48a/ benchmarks/ | ||
| # note the created prefix: main_(first-8-characters-of-commit), for convenienve export it | ||
| export PREFIX=benchmarks/main_3abfa48a/ | ||
| pytest --benchmark-compare -k getsize --benchmark-group-by=group,func,param --benchmark-columns=median --benchmark-sort=name --icechunk-prefix=$PREFIX benchmarks/ |
Contributor
There was a problem hiding this comment.
struggled with making a just command for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a natie version of:
Notably, it doesn't implement
getsize_prefix. We think letting zarr-python do the loop that callsgetsizecan be enough performance.