Skip to content

Conversation

@ianhi
Copy link
Collaborator

@ianhi ianhi commented Oct 14, 2025

Fixes: #1298

Initially opening without the fix to check that the new min version tests introduced here would have caught this.

@ianhi
Copy link
Collaborator Author

ianhi commented Oct 14, 2025

    
>       self.xarray_store = ZarrStore.open_group(
            store=self.store,
            group=group,
            mode=concrete_mode,
            zarr_format=3,
            append_dim=append_dim,
            write_region=region,
            safe_chunks=self.safe_chunks,
            align_chunks=self.align_chunks,
            synchronizer=None,
            consolidated=False,
            consolidate_on_close=False,
            zarr_version=None,
        )
E       TypeError: ZarrStore.open_group() got an unexpected keyword argument 'align_chunks'

nice! it caught it

)


@pytest.mark.skipif(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can't be right; it's been running so far!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was a bit confusing. but i saw very consistent failures on the min version tests

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree that this seems wrong though


pytestmark = pytest.mark.skipif(
Version(zarr.__version__) < Version("3.1.0"),
reason="BytesCodec Issuess with less than 3.1.0",
Copy link
Contributor

@dcherian dcherian Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we just need to skip when dtype.kind == "S"? If so we can use hypothesis.strategies.assume in the body of the test. It'd be nice to be much narrower here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will look into it

uv pip install pytest-mypy-plugins
# Install specific xarray version based on matrix
if [ "${{ matrix.xarray-version.version }}" = "latest" ]; then
echo "Using xarray from git checkout (latest)"
Copy link
Contributor

@dcherian dcherian Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's have this be the latest released versions. Otherwise our PRs will start failing when there's some Xarray/Zarr incompatibility on their main branches. we already run nightly upstream tests.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call. Although the nightly tests don't actually test the backends :(

Also I'm somewhat shocked that this never failed in the past. it's always been checking out the latest git version, not the most recent release.

I'll look into grabbing the xarray verssion and using that to checkout, but it may get a bit complicated.

@ianhi
Copy link
Collaborator Author

ianhi commented Oct 16, 2025

ok this is ready now!

The pending tests:

image

are that way because the github settings require those tests, but we no longer have tests by those names (because of teh version info in the test name) so I can update that post merge

@dcherian dcherian enabled auto-merge (squash) October 16, 2025 19:54
@dcherian
Copy link
Contributor

@jhamman or @paraseba you'll need to change the "required" check list for us to merge this

@ianhi ianhi disabled auto-merge October 16, 2025 20:06
@ianhi ianhi merged commit 11dafb9 into main Oct 16, 2025
17 checks passed
@ianhi ianhi deleted the ian/backcompat branch October 16, 2025 20:06
@ianhi
Copy link
Collaborator Author

ianhi commented Oct 16, 2025

@jhamman or @paraseba you'll need to change the "required" check list for us to merge this

I have this power :) I will update those required checks now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ZarrStore.open_group got an unexpected keyword argument 'align_chunks'

3 participants