simplify dask check #1254
Merged
simplify dask check #1254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paraseba
approved these changes
Sep 25, 2025
Contributor
dcherian
reviewed
Oct 13, 2025
ianhi
force-pushed
the
ian/pyright-errors
branch
from
32f9ef5 to
595226a
Compare
dcherian
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by some pyright warnings I was getting about directly using both dask.base and importlib.util we were apparently relying on not perfectly defined import behavior https://discuss.python.org/t/python3-11-importlib-no-longer-exposes-util/25641/23
this simplifies this a bit and removes the warnings that were driving me nuts, and i think is slightly more secure against weird importing importlib errors.