Apply formatting suggestions automatically #1218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paraseba
approved these changes
Sep 10, 2025
Contributor
Author
|
Some CI tests are failing, which I don't think are related to my change? But apparently I don't have the rights to force the merge regardless. |
Collaborator
|
@TomNicholas If you open this same PR from a branch on this repo, rather than from a fork they will pass. It's a complciation with hiding secrets from external PRs. I have a fix in the works. But for now i think it's ok for us to bypass right @paraseba ? I have the rights to make that happen if need be |
Collaborator
|
It's weird that you don't get the secrets applied @TomNicholas . I thought people in the GH org would 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the rust formatter from merely suggesting formatting changes to always applying them. It's not very helpful to have them suggested but then have to manually apply them.