Reduce LWIP flash 5.4K by cleaning debug prints #3154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In non-debug cases the string to `panic()` isn't actually sent to the
Serial port, or anywhere in fact.
When there is no debug port defined, replace the panic(str) of
LWIP_PLATFORM_ASSERT with panic("lwip") instead. This doesn't
effect debugging because the source line of the LWIP_ASSERT
will still show the full string (GDB shows the source).
Also, LWIP_DEBUG is a flag by definition, not value, so fix
lwipopts.h to not define it or the LWIP_X debug defines unless
LWIP_DEBUG is set by the compliation.
Saves 5480 bytes of flash for LWIP (Pico W, 2W, Ethernet) apps.
When -O3 is used to build LWIP, GCC emits a bogus error while compiling DHCP.C: > ../dhcp.c:1453:30: error: writing 1 byte into a region of size 0 DHCP_OPTIONS_LEN was verified as being DHCP_MIN_OPTIONS_LEN (68U) and not 0 using #ifs and #errors in the dhcp.h header, but GCC somehow forgets this while doing it's checks on O3. Looks to be a bug in GCC to me, so drop to -O2 for RP204 builds.
|
Original CI failure seems to show a GCC bug for the M3 (Pico2) where it thinks the DHCP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In non-debug cases the string to
panic()isn't actually sent to the Serial port, or anywhere in fact.When there is no debug port defined, replace the panic(str) of LWIP_PLATFORM_ASSERT with panic("lwip") instead. This doesn't effect debugging because the source line of the LWIP_ASSERT will still show the full string (GDB shows the source).
Also, LWIP_DEBUG is a flag by definition, not value, so fix lwipopts.h to not define it or the LWIP_X debug defines unless LWIP_DEBUG is set by the compliation.
Saves 5480 bytes of flash for LWIP (Pico W, 2W, Ethernet) apps.