RTEMS Serial Transport support #297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Build status:
|
roncapat
force-pushed
the
rtems_serial
branch
from
acb6fea to
973cb49
Compare
Contributor
|
Build status:
|
Contributor
|
Can you rebase this onto |
Signed-off-by: Patrick Roncagliolo <[email protected]>
Signed-off-by: Patrick Roncagliolo <[email protected]>
roncapat
force-pushed
the
rtems_serial
branch
from
973cb49 to
7f36b39
Compare
Contributor
Author
|
@pablogs9 done. Poll me if I have messed up something in the process. |
Contributor
|
Build status:
|
pablogs9
approved these changes
Dec 10, 2021
Contributor
pablogs9
left a comment
pablogs9
left a comment
There was a problem hiding this comment.
LGTM
@Acuadros95 S&M if you are ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #283 and #287, made a rapid patch for serial transport support.
Tested with PingPong app as usual.
Details about how to test this transport using QEMU will be added in micro-ROS/micro_ros_setup#397 tracker issue.
Note: as for TCP/UDP, this patch implements a variant of POSIX transports using
select()call instead ofpoll()call, which is not officially supported by RTEMS 5 core. Even if RTEMS-libBSD adds somepoll()support, many boards (BSPs) would be potentially excluded from microROS usage due to inability to build libBSD for them.