Skip to content

Conversation

jamoralp
Copy link
Contributor

@jamoralp jamoralp commented Sep 9, 2020

TODO:

  • Update to new transports API

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Windows Build Status

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Windows Build Status

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Windows Build Status

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Windows Build Status

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Windows Build Status

if (object_id->type == UXR_DATAREADER_ID)
{
uxrStreamId stream = {0, 0, UXR_BROKERLESS, UXR_INPUT_STREAM};
uxrStreamId stream = {0, 0, UXR_BROKERLESS_STREAM, UXR_INPUT_STREAM};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check this, have you changed the stream type enum also?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I just did it to maintain the coherence with the naming of the rest of the elements in the enum 🙂

char* ip = argv[1];
char* port = argv[2];
uint32_t key = (args == 4) ? (uint32_t)atoi(argv[3]) : 0xCCCCDDDD;
uint32_t key = 0xCCCCDDDD;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should not be changed. Remember: keep unchanged.

#define STREAM_HISTORY 8
#define BUFFER_SIZE UXR_CONFIG_UDP_TRANSPORT_MTU * STREAM_HISTORY

bool sended = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should not be changed. Remember: keep unchanged.

#define STREAM_HISTORY 8
#define BUFFER_SIZE UXR_CONFIG_UDP_TRANSPORT_MTU * STREAM_HISTORY

uint32_t last_index = -1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should not be changed. Remember: keep unchanged.

UXR_RELIABLE_STREAM
UXR_RELIABLE_STREAM,
/** Identifies a brokerless stream. */
UXR_BROKERLESS_STREAM
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the stream name, in the other file UXR_BROKERLESS_STREAM is not being used.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is ok. My fault.

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Windows Build Status

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Windows Build Status

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Windows Build Status

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Windows Build Status

@pablogs9 pablogs9 force-pushed the feature/brokerless_p2p branch from eb5aae4 to 223d69b Compare October 22, 2020 05:56
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Windows Build Status

@russkel
Copy link

russkel commented Jan 10, 2023

I think this is pretty cool - will it be worked on again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants