Skip to content

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jun 26, 2025

Description

This PR updates the Windows GitHub Action Runner from windows-2019 to windows-2022. As Visual Studio 2017 build tools (v141) are no longer installed in this new runner, the PR upgrades also to toolsets to use, moving from v141 (VS2017) and v142 (VS2019) to v142 (VS2019) and v143 (VS2022).

@Mergifyio backport 2.2.x 1.0.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: CI pass and failing tests are unrelated with the changes.

This is an automatic backport of pull request #270 done by [Mergify](https://mergify.com).

* Remove deprecated windows-2019 runner

Signed-off-by: Raul Sanchez-Mateos <[email protected]>

* Upgrade Visual Studio toolset from v141 to v143

Signed-off-by: Raul Sanchez-Mateos <[email protected]>

* Upgrade missing vs-toolset config

Signed-off-by: Raul Sanchez-Mateos <[email protected]>

---------

Signed-off-by: Raul Sanchez-Mateos <[email protected]>
(cherry picked from commit eac23fb)

# Conflicts:
#	.github/workflows/nightly-windows-ci.yml
#	.github/workflows/windows-ci.yml
@mergify mergify bot added the conflicts label Jun 26, 2025
Copy link
Author

mergify bot commented Jun 26, 2025

Cherry-pick of eac23fb has failed:

On branch mergify/bp/1.0.x/pr-270
Your branch is up to date with 'origin/1.0.x'.

You are currently cherry-picking commit eac23fb.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .github/workflows/codeql-analysis.yml
	modified:   QUALITY.md

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   .github/workflows/nightly-windows-ci.yml
	both modified:   .github/workflows/windows-ci.yml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@MiguelCompany MiguelCompany added this to the v1.0.29 milestone Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants