Return failed step in the reason

[dobrac]

This is a breaking change, but in the new SDK, so it's acceptable. The old Template SDK versions will show [object Object] instead of the reason, this will be fixed in the new SDK release.

Return failed step in the reason for the build. This changes the original reason format to:

BuildStatusReason:
  required:
    - message
  properties:
    message:
      type: string
      description: Message with the status reason, currently reporting only for error status
    step:
      type: string
      description: Step that failed

The step value can be either:

• base
• step number (like 3)
• finalize

The reason is saved in the DB as serialized JSON instead of just a string message (the string reason was never actually saved, there was a bug).

This PR also reduce error wrapping for main paths where the error source is obvious.

[linear]

E2B-2751 Return failed step in the reason

[dobrac]

Bug: BuildStatusReason Violates API Contract

The OpenAPI schema for BuildStatusReason defines both message and step as required fields. However, the codebase frequently constructs BuildStatusReason objects with an empty step field in various scenarios, such as build timeouts, general failures, cancelled builds, and when deserializing malformed JSON. This violates the API contract and can cause client-side validation errors.

spec/openapi.yml#L672-L683
packages/api/internal/utils/build_status_reason.go#L49-L54
packages/orchestrator/internal/template/build/builderrors/errors.go#L16-L20
packages/api/internal/template-manager/template_status.go#L43-L46
packages/api/internal/template-manager/create_template.go#L61-L64
packages/orchestrator/internal/template/server/delete_template.go#L36-L39
packages/api/internal/template-manager/template_status.go#L264-L267

Bug: Context Cancellation Error Masked

When the main context is cancelled, the error reported incorrectly wraps a stale err variable from a previous operation instead of the actual context cancellation error (ctx.Err()).

packages/orchestrator/internal/template/build/phases/finalize/builder.go#L258-L265

Comment @cursor review or bugbot run to trigger another review on this PR

both fixed

[jakubno]

why do we have it as a string in db and not json?

[dobrac]

forgot about that, thx, will add a migration

[jakubno]

I am mainly asking about why we don't save it to DB as a json, why do we do the parsing ourself

[dobrac]

changed the column type to jsonb + added migration

[dobrac]

@cursor review

[cursor]

✅ Bugbot reviewed your changes and found no bugs!

Comment @cursor review or bugbot run to trigger another review on this PR