Skip to content

Conversation

@dobrac
Copy link
Contributor

@dobrac dobrac commented Oct 22, 2025

cleanup the template build messages:

  • include the start command in the log message
  • send only one log message when running the ready command
  • change level to debug for the log message when the template is not ready
  • do not print the exit status as it's already included in the error message. Let the downstream handle it itself
  • log stderr as info level, not error (for a lot of tools, stderr is not an error)

Note

Streamline template build logs: include start command, consolidate ready message, downgrade non-ready logs to debug, align stderr log level, and avoid duplicate exit status; update tests accordingly.

  • Orchestrator (template build):
    • Start: Log includes the command (builder.go), e.g., Running start command: <cmd>.
    • Ready:
      • Consolidate to a single info log: Waiting for template to be ready: <cmd> (ready.go).
      • Run ready command logs at DebugLevel and downgrade "not ready" messages to debug.
    • Command I/O:
      • Log stderr at the provided level (not forced to error) and avoid duplicate exit status output (sandboxtools/command.go).
  • Tests:
    • Update expected logs to match new messages/levels in tests/integration/internal/tests/api/templates/build_template_test.go.

Written by Cursor Bugbot for commit fef5b00. This will update automatically on new commits. Configure here.

@dobrac dobrac force-pushed the cleanup-template-building-messages branch from a62bf78 to c0cd4c0 Compare October 22, 2025 23:10
@dobrac dobrac added the improvement Improvement for current functionality label Oct 22, 2025
@dobrac dobrac marked this pull request as ready for review October 22, 2025 23:15
@dobrac dobrac enabled auto-merge (squash) October 22, 2025 23:17
@dobrac dobrac merged commit ff7a107 into main Oct 22, 2025
26 checks passed
@dobrac dobrac deleted the cleanup-template-building-messages branch October 22, 2025 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement for current functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants