- 
                Notifications
    You must be signed in to change notification settings 
- Fork 180
Don't assume an orchestrator port number, but pull it from nomad #1368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    sitole
  
              
              reviewed
              
                  
                    Oct 17, 2025 
                  
              
              
            
            
              
                    sitole
  
              
              reviewed
              
                  
                    Oct 21, 2025 
                  
              
              
            
            
              
                    ValentaTomas
  
              
              approved these changes
              
                  
                    Oct 29, 2025 
                  
              
              
            
            
    
  djeebus 
      added a commit
      that referenced
      this pull request
    
      Oct 31, 2025 
    
    
  
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
This keeps support for assuming an orchestrator port number, but only as a fallback. This allows us to place orchestrators where ever we want, with whatever port number we want, and the API will find them.
Note
API now discovers orchestrator IP/port from Nomad allocation resources (label
grpc), with a configurable default fallback; Nomad job defines labeled ports and env wired from Nomad.ClientStatus == "running" and JobID contains "orchestrator-".isHealthyand resolve address by scanningAllocatedResourcesfor port labelo.portLabel(fallback too.defaultPort).NomadServiceDiscoveryfrom allocation IP/port; logs when missing/found.isHealthyand port resolution across reserved/dynamic/shared networks inclient_test.go.Config.DefaultOrchestratorPort(deprecated fallback) andConfig.OrchestratorPortLabel(defaultgrpc).defaultPortandportLabelintoOrchestrator.iac/provider-gcp/nomad/jobs/orchestrator.hcl):network { mode = "host" }with labeled portsgrpcandproxy; services reference labels.GRPC_PORT/PROXY_PORTfrom$${NOMAD_PORT_grpc}/$${NOMAD_PORT_proxy}.OrchestratorPortfrompackages/shared/pkg/consts/sandboxes.go.Written by Cursor Bugbot for commit bd75947. This will update automatically on new commits. Configure here.