-
Notifications
You must be signed in to change notification settings - Fork 183
Speedup docker build with cached deps, remove need for dot folders #1365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubno
approved these changes
Oct 16, 2025
| COPY ./db/client ./db/client | ||
| COPY ./db/dberrors ./db/dberrors | ||
| COPY ./db/queries ./db/queries | ||
| COPY ./db/types ./db/types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you move this to /pkg in a next PR? 🙏🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep
Code42Cate
pushed a commit
that referenced
this pull request
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
packagesdirectory.Note
Refactors Dockerfiles and Makefiles to cache Go modules and build from parent directory, removing dot-folder copies and updating paths/binaries accordingly.
go mod downloadbefore source copy inpackages/*/Dockerfile(api,client-proxy,db,docker-reverse-proxy,orchestrator) to leverage layer caching..shared/.db/.clickhousecopies with direct./shared,./db,./clickhouse,./<service>paths; adjustWORKDIRs andCOPYsources accordingly.dbmigrator to./bin/migrator) and ENTRYPOINT arrays; update final image COPY paths.build-and-upload(andbuild) targets to usedocker build ... -f ./Dockerfile .., removing temporary dot-folder creation/cleanup acrossapi,client-proxy,db,docker-reverse-proxy,orchestrator.Written by Cursor Bugbot for commit 8d3aac5. This will update automatically on new commits. Configure here.