-
Couldn't load subscription status.
- Fork 180
feat: keep user and workdir from the template in the sandbox #1349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dobrac
merged 15 commits into
main
from
figure-out-default-user-template-root-sandbox-user-eng-3049
Oct 14, 2025
Merged
feat: keep user and workdir from the template in the sandbox #1349
dobrac
merged 15 commits into
main
from
figure-out-default-user-template-root-sandbox-user-eng-3049
Oct 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2a582b7 to
0d9d802
Compare
2ff2f59 to
8f679fa
Compare
8f679fa to
b21ee0a
Compare
jakubno
requested changes
Oct 14, 2025
b092565 to
e1e0764
Compare
e1e0764 to
6976e56
Compare
jakubno
requested changes
Oct 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NITs
ba40582 to
daec35f
Compare
jakubno
approved these changes
Oct 14, 2025
jakubno
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Note
Adds template versioning (v1/v2) with SDK-based selection and propagates template-defined default user/workdir into sandboxes, updating envd API, build phases, and gRPC contracts accordingly.
User-Agent(JS/Python); v1 handler forcestemplates.TemplateV1Version.versionthrough API → template-manager → orchestrator; proto gainsTemplateCreateRequest.version.templatesversion constants and version utils.userphase to create/configure default user (sudo) and persist in metadata.WORKDIRto resolve/normalize absolute paths and safe chowning.POST /initsupportsdefaultUseranddefaultWorkdir./filesis optional; auth/signing and path resolution handle missing username via defaults and workdir.0.4.0.User-Agent; fixes success flag; unified error handling.username, new init fields).Written by Cursor Bugbot for commit 9798fbb. This will update automatically on new commits. Configure here.