Improve build cancellation error message #1330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e2b-request-same-site-reviewers
bot
requested review from
jakubno
and removed request for
ValentaTomas and
jakubno
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
dobrac
changed the title
Co-authored-by: Jakub Novák <[email protected]>
Co-authored-by: Jakub Novák <[email protected]>
jakubno
approved these changes
Oct 9, 2025
jakubno
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should hide the cryptic error messages when the build is simply cancelled.
Note
Standardizes the canceled-build reason constant and updates builder logging to explicitly handle context cancellation, with server delete flow using the new constant.
builder.gonow treatscontext.Canceleddistinctly and logs a clear cancellation message usingbuildcache.CanceledBuildReason.CancelledBuildReasonvar toconst CanceledBuildReasonintemplate/cache/build_cache.go.server/delete_template.goupdated to referencecache.CanceledBuildReasonwhen marking running builds as failed.Written by Cursor Bugbot for commit 082939d. This will update automatically on new commits. Configure here.