Skip to content

Conversation

@jakubno
Copy link
Member

@jakubno jakubno commented Oct 6, 2025

Note

Only set system time during init when timestamp deviates beyond small thresholds; otherwise skip and log.

  • Backend (packages/envd/internal/api/init.go):
    • Time setting logic: Introduce maxTimeInPast (50ms) and maxTimeInFuture (5s) thresholds and only call unix.ClockSettime when data.Timestamp is outside this window.
    • Adds debug logging when the timestamp is within the window and the system time update is skipped.

Written by Cursor Bugbot for commit 189d0be. This will update automatically on new commits. Configure here.

@e2b-request-same-site-reviewers e2b-request-same-site-reviewers bot requested review from sitole and removed request for ValentaTomas and dobrac October 6, 2025 15:14
cursor[bot]

This comment was marked as outdated.

@jakubno jakubno force-pushed the envd-jump-only-forwards branch from 09a01ad to aa544c4 Compare October 6, 2025 15:18
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@jakubno jakubno force-pushed the envd-jump-only-forwards branch from 37ce5f7 to b01ea62 Compare October 6, 2025 15:37
cursor[bot]

This comment was marked as outdated.

@jakubno jakubno changed the title Envd jump only forwards Envd prevent unnecessary jumps Oct 6, 2025
@jakubno
Copy link
Member Author

jakubno commented Oct 6, 2025

bugbot run

cursor[bot]

This comment was marked as outdated.

@jakubno jakubno enabled auto-merge (squash) October 6, 2025 16:00
@jakubno jakubno merged commit 7f1a88e into main Oct 6, 2025
45 of 46 checks passed
@jakubno jakubno deleted the envd-jump-only-forwards branch October 6, 2025 16:11
Code42Cate pushed a commit that referenced this pull request Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants