Send sandbox routing data to shared Redis storage via catalog impl #1298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redis lock was global that is possible bottleneck when there is big number of concurrently spawned sandboxes. Now catalog create and delete is called from api that is single running instance so there should be no issue.
Now new memory cache ttl is 500ms replacing original 5s that can cause race conditions when you will run sadnbox, pause and resume on another node fast, some edge proxy instances can still route your traffic to old node.
Member
Author
|
You can try with changes from 4f34122 that will disable DNS check on client proxy, and only the sandbox catalog backed by Redis will be used. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jakubno
requested changes
Oct 6, 2025
packages/client-proxy/internal/edge/handlers/sandbox-catalog-create-entry.go
Outdated
Show resolved
Hide resolved
jakubno
approved these changes
Oct 6, 2025
jakubno
deleted the
fix/client-proxy-use-redis-for-routing-instead-of-dns-eng-3125
branch
Code42Cate
pushed a commit
that referenced
this pull request
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Integrates a shared sandbox catalog (Redis/memory) across API DNS and client-proxy, replacing prior sandboxes impl and locks, simplifying sandbox resolution, and bumping ttlcache.
sandbox-catalogpackage (packages/shared/pkg/sandbox-catalog): definesSandboxesCatalogwithSandboxInfo(addsOrchestratorIP), memory and Redis impls.sandbox:catalog:<id>; tighter timeouts and error handling.github.com/jellydator/ttlcache/v3tov3.4.0across modules.internal/dns/server.go): switch from localsmapto catalog usage;Add/Removenow acceptSandboxInfo/executionIDand persist routing in catalog.SandboxInfo(incl.OrchestratorIP, max lifetime) on add; remove viaexecutionID.edge/sandboxeswith sharedsandbox-catalogin pass-through events, REST handlers, proxy, and service wiring.OrchestratorIP; proxy resolution reads IP directly andNewClientProxydrops orchestrators pool param.Ip->IP), logging/telemetry tweaks, and service discovery/logger alias cleanups.Written by Cursor Bugbot for commit 4885309. This will update automatically on new commits. Configure here.