Refactor template request common methods

[dobrac]

Refactor template request common methods (just moved around).

[dobrac]

Telemetry Misreports Errors After Build Failures

Valid issues, but not new here. They'll be fixed in another PR (#1249)

[cursor]

Bug: Variable Shadowing and Error Reporting Issues

The template variable shadows the imported template package in both template_request_build_v2.go and template_request_build.go, causing a compilation error. Additionally, telemetry reporting in both files logs the body parsing error (err) instead of the actual template build error (apiError.Err), leading to misleading error information.

packages/api/internal/handlers/template_request_build_v2.go#L78-L84

infra/packages/api/internal/handlers/template_request_build_v2.go

Lines 78 to 84 in f7d0b7c

	template, apiError := template.RegisterBuild(ctx, a.templateBuildsCache, a.db, a.sqlcDB, buildReq)
	if apiError != nil {
	a.sendAPIStoreError(c, apiError.Code, apiError.ClientMsg)
	telemetry.ReportCriticalError(ctx, "invalid request body", err)
	return
	}

packages/api/internal/handlers/template_request_build.go#L104-L110

infra/packages/api/internal/handlers/template_request_build.go

Lines 104 to 110 in f7d0b7c

	template, apiError := template.RegisterBuild(ctx, a.templateBuildsCache, a.db, a.sqlcDB, buildReq)
	if apiError != nil {
	a.sendAPIStoreError(c, apiError.Code, apiError.ClientMsg)
	telemetry.ReportCriticalError(ctx, "build template request failed", err)
	return nil
	}

 

---

Bug: Template Shadowing and Telemetry Error

The TemplateRequestBuild function introduces a compilation error where the template variable shadows the imported template package. It also incorrectly reports build failures to telemetry by using an unrelated error variable.

packages/api/internal/handlers/template_request_build.go#L104-L108

infra/packages/api/internal/handlers/template_request_build.go

Lines 104 to 108 in f7d0b7c

	template, apiError := template.RegisterBuild(ctx, a.templateBuildsCache, a.db, a.sqlcDB, buildReq)
	if apiError != nil {
	a.sendAPIStoreError(c, apiError.Code, apiError.ClientMsg)
	telemetry.ReportCriticalError(ctx, "build template request failed", err)

 

---