Support overriding orchestrator paths #1238
Merged
+32
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
running the orchestrator against /orchestrator and writing the pid file to / isn't a great idea for local dev
djeebus
requested review from
ValentaTomas,
dobrac and
jakubno
as code owners
|
@djeebus, can we split into overriding paths and adding the lock functionality (which I think is new)? |
jakubno
approved these changes
Sep 23, 2025
it was there before, it's preventing orchestrator to restart |
|
Got it, was confused as it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
running the orchestrator against /orchestrator and writing the pid file to / isn't great for local dev.
ORCHESTRATOR_LOCK_PATH(defaults to "/orchestrator.lock")ORCHESTRATOR_BASE_PATH(defaults to "/orchestrator")