Handle fromTemplate with template status instead of API error

[dobrac]

Handle fromTemplate with template status instead of API error. This unifies the handling the SDK afterwards.

[linear]

ENG-3016 Handle fromTemplate with template status instead of API error

[cursor]

Bug: Error Overwrite in Template Status Handling

The err variable is reassigned when calling tm.SetStatus, causing err.Error() to use the tm.SetStatus error instead of the original FromTemplateError. This results in an incorrect build status message. If tm.SetStatus fails, the function returns an error, which may trigger a deferred status update, leading to double status setting or overwriting the message.

packages/api/internal/template-manager/create_template.go#L132-L146

infra/packages/api/internal/template-manager/create_template.go

Lines 132 to 146 in f851af6

	err = tm.SetStatus(
	ctx,
	templateID,
	buildID,
	envbuild.StatusFailed,
	&templatemanagergrpc.TemplateBuildStatusReason{
	Message: err.Error(),
	Step: ut.ToPtr("base"),
	},
	)
	if err != nil {
	return fmt.Errorf("failed to set build status: %w", err)
	}
	return nil

 

---