Skip to content

Add fallback for getting the template builder #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 12, 2025
Merged

Add fallback for getting the template builder #1164

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
39e8071
Add fallback
jakubno Sep 12, 2025
dffb96d
Update packages/api/internal/template-manager/template_manager.go
jakubno Sep 12, 2025
e07dd1f
Update packages/api/internal/template-manager/template_manager.go
jakubno Sep 12, 2025
0a9e825
Update packages/api/internal/template-manager/template_manager.go
jakubno Sep 12, 2025
50673ec
Merge branch 'main' into fix-build-and-snapshots-cleanup
jakubno Sep 12, 2025
9813de0
Remove new line
jakubno Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion packages/api/internal/template-manager/template_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,19 @@ func (tm *TemplateManager) DeleteBuild(ctx context.Context, buildID uuid.UUID, t

client, err := tm.GetClusterBuildClient(clusterID, nodeID)
if err != nil {
return fmt.Errorf("failed to get builder client: %w", err)
// nodeID can be an orchestrator ID, if the build corresponds to a snapshot.
// We may want to improve this later by adding the Delete method to Orchestrator as well.
// This way we can remove the build (snapshot) from cache as well
nodeID, err = tm.GetAvailableBuildClient(ctx, clusterID)
if err != nil {
return fmt.Errorf("failed to get any available node in the cluster: %w", err)
}

zap.L().Info("Fallback to available node", zap.String("nodeID", nodeID), zap.String("clusterID", clusterID.String()))
client, err = tm.GetClusterBuildClient(clusterID, nodeID)
if err != nil {
return fmt.Errorf("failed to get builder client: %w", err)
}
}

reqCtx := metadata.NewOutgoingContext(ctx, client.GRPC.Metadata)
Expand Down
Loading