Skip to content

AWS Storage provider was ignoring errors during delete #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 12, 2025
Merged

AWS Storage provider was ignoring errors during delete #1163

merged 2 commits into from
Sep 12, 2025

Conversation

@sitole
Copy link
Member

@sitole sitole commented Sep 12, 2025

  • Check if there are any errors during delete request
  • Check if any per-object errors are returned
  • Check if number of deleted objects is same as objects we are requesting to be deleted

@sitole sitole self-assigned this Sep 12, 2025
@sitole sitole added the bug Something isn't working label Sep 12, 2025
@sitole
Copy link
Member Author

sitole commented Sep 12, 2025

Not checking per-object errors was causing an error with a typo in IAM permissions to stay hidden.

@sitole sitole marked this pull request as ready for review September 12, 2025 09:07
@sitole sitole merged commit 818a9a8 into main Sep 12, 2025
26 checks passed
@sitole sitole deleted the chore/orchestrator-as-docker-image branch September 12, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakubno jakubno jakubno approved these changes

@ValentaTomas ValentaTomas Awaiting requested review from ValentaTomas ValentaTomas is a code owner

@dobrac dobrac Awaiting requested review from dobrac dobrac is a code owner

Assignees

@sitole sitole

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sitole @jakubno