Support cpu platform and disk type configuration #1123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djeebus
requested review from
ValentaTomas,
dobrac and
jakubno
as code owners
jakubno
requested changes
Sep 4, 2025
|
|
||
| variable "client_min_cpu_platform" { | ||
| type = string | ||
| default = "Intel Skylake" |
There was a problem hiding this comment.
The family must be the same for builder and client
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jakubno
reviewed
Sep 4, 2025
|
Also these variable should be exposed via Makefile |
djeebus
force-pushed
the
support-config
branch
from
7d224ab to
a1b0bbe
Compare
jakubno
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes a few fields to customize the cpu and disk type for the build and client nodes, but keeps the defaults the same.