Skip to content

Fix regression for envd watcher #1099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 1, 2025
Merged

Fix regression for envd watcher #1099

merged 2 commits into from
Sep 1, 2025

Conversation

@jakubno
Copy link
Member

@jakubno jakubno commented Sep 1, 2025 •
edited
Loading

  • This pull request fixes an issue where watcher was closed right after the request for create was completed (introduced in #981)
  • Added a integration test (fails without the patch)

@jakubno jakubno self-assigned this Sep 1, 2025
@jakubno jakubno added the bug Something isn't working label Sep 1, 2025
@jakubno jakubno merged commit 90c56fc into main Sep 1, 2025
26 checks passed
@jakubno jakubno deleted the fix-sync-file-watcher-regression branch September 1, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ValentaTomas ValentaTomas ValentaTomas approved these changes

@dobrac dobrac Awaiting requested review from dobrac dobrac is a code owner

Assignees

@jakubno jakubno

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jakubno @ValentaTomas