Skip to content

fix(fastapi): invalid utf8 header values are now not breaking trace #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bwcgn wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(fastapi): invalid utf8 header values are now not breaking trace #114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions autodynatrace/wrappers/fastapi/middleware.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ async def __call__(self, scope, receive, send):
request_headers = scope.get("headers", [])
headers = {}
for key, value in request_headers:
key = key.decode() if isinstance(key, bytes) else key
value = value.decode() if isinstance(value, bytes) else value
key = key.decode('utf-8', errors='replace') if isinstance(key, bytes) else key
value = value.decode('utf-8', errors='replace') if isinstance(value, bytes) else value
headers[key.lower()] = value

dt_tag = headers.get("x-dynatrace")
Expand Down Expand Up @@ -55,8 +55,8 @@ async def wrapped_send(message):
if "headers" in message:
response_headers = {}
for k, v in message["headers"]:
k = k.decode() if isinstance(k, bytes) else k
v = v.decode() if isinstance(v, bytes) else v
k = k.decode('utf-8', errors='replace') if isinstance(k, bytes) else k
v = v.decode('utf-8', errors='replace') if isinstance(v, bytes) else v
response_headers[k.lower()] = v

tracer.add_response_headers(response_headers)
Expand Down