No longer store MethodData as static variables #365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s mutates the MethodData, and thus it's not thread safe. Fix dynamicexpresso#361 Fix dynamicexpresso#364
|
@metoule What are your thoughts on having the static fields and updated method signatures be Method base instead of the SimpleMethodSignature? Obviously the actual ones you return would still be the simple class. This may allow us to transform some things going forward if we make further changes/optimizations around how these operations are looked up. |
|
@metoule Thank you! Just a question to fully understand: |
In |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#349 (via commit 0346c9d) removed the reflection code that was used to know the operands of binary and unary operators. Instead, it stored
MethodDataobject as static objects, so that they could directly be used during the resolution process.That proved to be an ill-advised choice: the resolution process mutates the
MethodDataclass, but since they're stored as static variables, it was not thread-safe: thanks @mats-boisen for the investigation in #364!This PR instead stores immutable objects as static variables. The
MethodDataused during resolution is therefore created for each resolution.Fix #361
Fix #364