Modernize to match RFC 4648 #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was prompted by @housel noting that `base64-encode` only accepted a string as input. That function has been updated to accept any sequence of bytes or byte characters. Padding with "=" is now supported. The standard and URL-safe character sets documented in RFC 4648 are supported. There is still no support for line breaks, whitespace, or streaming.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was prompted by @housel noting that
base64-encodeonly accepted a string as input. That function has been updated to accept any sequence of bytes or byte characters.Padding with "=" is now supported.
The standard and URL-safe character sets documented in RFC 4648 are supported.
There is still no support for line breaks, whitespace, or streaming.