Skip to content

Remove shadcn from exclude list #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove shadcn from exclude list #769

wants to merge 2 commits into from

Conversation

wwwillchen
Copy link
Contributor

No description provided.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic analysis

No issues found across 1 file. Review in cubic

!shouldReadFileContentsForSmartContext({
filePath: file,
})
) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Inconsistent File Handling Causes Security Vulnerability

The codebase extraction exhibits inconsistent handling of omitted files. The formatFile function, which populates formattedOutput, continues to use shouldReadFileContents, respecting OMITTED_FILES (e.g., src/components/ui) and replacing their content with placeholders. Conversely, the logic for the files array now uses shouldReadFileContentsForSmartContext, which intentionally bypasses the omitted files check. This results in the same file appearing with placeholder content in formattedOutput but its actual content in the files array. This inconsistency also poses a security risk, as sensitive files like .env that should be omitted may now have their actual contents exposed in the files array.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant