Intercept ctrl/command R for refresh #759
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic analysis
1 issue found across 1 file • Review in cubic
React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai to give feedback, ask questions, or re-run the review.
src/app/layout.tsx
Outdated
| if (event.key === "r" && (event.ctrlKey || event.metaKey)) { | ||
| event.preventDefault(); // Prevent default browser refresh | ||
| if (previewMode === "preview") { | ||
| console.log("REFRESHING APP IFRAME"); |
There was a problem hiding this comment.
Replace console.log with the logging framework.
(This reflects your team's feedback about avoiding console statements in production code.)
Prompt for AI agents
Address the following comment on src/app/layout.tsx at line 26:
<comment>Replace console.log with the logging framework.
(This reflects your team's feedback about avoiding console statements in production code.)</comment>
<file context>
@@ -4,12 +4,40 @@ import { ThemeProvider } from "../contexts/ThemeContext";
import { DeepLinkProvider } from "../contexts/DeepLinkContext";
import { Toaster } from "sonner";
import { TitleBar } from "./TitleBar";
+import { useEffect } from "react";
+import { useRunApp } from "@/hooks/useRunApp";
+import { useAtomValue } from "jotai";
+import { previewModeAtom } from "@/atoms/appAtoms";
export default function RootLayout({
</file context>
| if (previewMode === "preview") { | ||
| refreshAppIframe(); // Use our custom refresh function instead | ||
| } | ||
| } |
There was a problem hiding this comment.
Bug: Refresh Key Listener Fails Outside Preview
The global keyboard listener for refresh events unconditionally prevents the default browser refresh (Ctrl/Cmd+R), but only provides a custom refresh when in preview mode. This causes Ctrl/Cmd+R to do nothing outside of preview mode. Additionally, the listener only checks for the lowercase "r" key, failing to intercept Ctrl/Cmd+Shift+R.
Locations (1)
Fixes #209