Show code snippet in fix problems

[wwwillchen]

No description provided.

[cubic-dev-ai]

cubic analysis

3 issues found across 4 files • Review in cubic

_{React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai to give feedback, ask questions, or re-run the review.}

[cubic-dev-ai]

Code snippet is inserted into a Markdown code block without escaping, which could break formatting or allow prompt injection if the snippet contains triple backticks or other Markdown syntax.

Prompt for AI agents

Address the following comment on src/shared/problem_prompt.ts at line 19:

<comment>Code snippet is inserted into a Markdown code block without escaping, which could break formatting or allow prompt injection if the snippet contains triple backticks or other Markdown syntax.</comment>

<file context>
@@ -16,6 +16,10 @@ export function createProblemFixPrompt(problemReport: ProblemReport): string {
 
   problems.forEach((problem, index) =&gt; {
     prompt += `${index + 1}. ${problem.file}:${problem.line}:${problem.column} - ${problem.message} (TS${problem.code})\n`;
+    if (problem.snippet) {
+      prompt += `\`\`\`\n${problem.snippet}\n\`\`\`\n`;
+    }
</file context>

[cubic-dev-ai]

Use trimEnd() so trailing new-lines are removed while preserving leading indentation needed for a readable code snippet. (Based on your team's feedback about preserving code formatting in snippets)

Prompt for AI agents

Address the following comment on workers/tsc/tsc_worker.ts at line 209:

<comment>Use trimEnd() so trailing new-lines are removed while preserving leading indentation needed for a readable code snippet. (Based on your team&#39;s feedback about preserving code formatting in snippets)</comment>

<file context>
@@ -188,12 +188,25 @@ async function runSingleProject(
       continue;
     }
 
+    // Extract the problematic line with context
+    const sourceLines = diagnostic.file.getFullText().split(&quot;\n&quot;);
+    const lineBefore = line &gt; 0 ? sourceLines[line - 1] : &quot;&quot;;
+    const problematicLine = sourceLines[line] || &quot;&quot;;
+    const lineAfter =
+      line &lt; sourceLines.length - 1 ? sourceLines[line + 1] : &quot;&quot;;
</file context>

Suggested change

	snippet: snippet.trim(),
	snippet: snippet.trimEnd(),

[cubic-dev-ai]

Use a CR-LF tolerant splitter so snippets render correctly on Windows too.

Prompt for AI agents

Address the following comment on workers/tsc/tsc_worker.ts at line 192:

<comment>Use a CR-LF tolerant splitter so snippets render correctly on Windows too.</comment>

<file context>
@@ -188,12 +188,25 @@ async function runSingleProject(
       continue;
     }
 
+    // Extract the problematic line with context
+    const sourceLines = diagnostic.file.getFullText().split(&quot;\n&quot;);
+    const lineBefore = line &gt; 0 ? sourceLines[line - 1] : &quot;&quot;;
+    const problematicLine = sourceLines[line] || &quot;&quot;;
</file context>

Suggested change

	const sourceLines = diagnostic.file.getFullText().split("\n");
	const sourceLines = diagnostic.file.getFullText().split(/\r?\n/);