feat(icon): more elegant, adjust the opacity of the expand button to 32% #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That looks really nice. That said, this variation measures out to a WCAG contrast of ~1.7 for both the light and dark variants – far below the accessible minimum contrast of 4.0. I.e. people with vision issues, often just due to age, won't be able to make out that icon. My suggestion: add an option to toggle back to the original (or at least, higher) contrast icon. |
|
Take a look in on my issue. What do you think? It's sound the same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
What are the relevant Git tickets?
None
Screenshots (if appropriate)
Any background context you want to provide? (if appropriate)
idea: less conspicuous, overall more coordinated