Skip to content

Conversation

@fedang
Copy link
Contributor

@fedang fedang commented Oct 7, 2025

the use of file names instead of some glob seems silly, but I couldn't figure out a smarter way

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.02%. Comparing base (fdcda3d) to head (e87899e).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1511   +/-   ##
=======================================
  Coverage   65.02%   65.02%           
=======================================
  Files          51       51           
  Lines        9129     9129           
  Branches     1064     1064           
=======================================
  Hits         5936     5936           
  Misses       3193     3193           
Flag Coverage Δ
unittests 65.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@CelDaemon
Copy link
Contributor

the use of file names instead of some glob seems silly, but I couldn't figure out a smarter way

A smarter way isn't needed, meson doesn't support glob for performance reasons and recommends manually specifying files.
The same thing is also done in the rest of the project, like in src/meson.build:

dunst/src/meson.build

Lines 1 to 19 in fdcda3d

dunst_src_files = files(
'dbus.c',
'draw.c',
'dunst.c',
'icon-lookup.c',
'icon.c',
'ini.c',
'input.c',
'log.c',
'markup.c',
'menu.c',
'notification.c',
'option_parser.c',
'output.c',
'queues.c',
'rules.c',
'settings.c',
'utils.c',
)

@fedang fedang merged commit a54fcd5 into dunst-project:master Oct 13, 2025
24 checks passed
@fedang fedang deleted the cleanup branch October 13, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants