Skip to content

Conversation

laghee
Copy link
Contributor

@laghee laghee commented Aug 29, 2025

Asana: https://app.asana.com/1/137249556945/task/1211021483002732?focus=true

  • Added a current version of Chrome.
  • Previously we weren't catching our shimmed Notification API because we were only grabbing enumerable properties.
  • We catch a couple hundred more properties by both enumerating and using Object.getOwnPropertyNames

👉 Object.getOwnPropertyNames only:
Screenshot 2025-08-29 at 16 00 03

👉 Object.getOwnPropertyNames + enumeration:
Screenshot 2025-08-29 at 16 15 33

Copy link
Member

@kdzwinel kdzwinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment, but otherwise LGTM. Sounds like @jonathanKingston had something to add though? I don't see his comment.

Copy link
Collaborator

@jonathanKingston jonathanKingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice hadn't seen this PR. Thanks for clearing up the changes from the other one!

@jonathanKingston jonathanKingston merged commit 8abf32e into main Sep 1, 2025
1 check passed
@jonathanKingston jonathanKingston deleted the km/expand-collection-jsleaks branch September 1, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants