Add expected pixels to ad click attribution test cases #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Pixel" requests are sent by the mechanism DuckDuckGo relies on to support ad click attribution in DuckDuckGo products. These help DuckDuckGo validate that the mechanism's logic is working correctly. Let's note the expected pixels in these shared test cases, so that each DuckDuckGo product can ensure those requests are being made correctly. Further reading: - https://duckduckgo.com/duckduckgo-help-pages/privacy/web-tracking-protections/#duckduckgo-private-search-ads - https://improving.duckduckgo.com/
englehardt
approved these changes
Aug 2, 2024
| } | ||
| }, | ||
| { | ||
| "name": "m_pageloads_with_ad_attribution", |
There was a problem hiding this comment.
There is an assumption here that for the test runner that we force this to fire at the end of each test case. I think that's okay, but just checking that it's expected.
There was a problem hiding this comment.
Yea, that's right. I would have mentioned that in a comment (like I did in the other version of this file) but unfortunately JSON doesn't support comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Pixel" requests are sent by the mechanism DuckDuckGo relies on to
support ad click attribution in DuckDuckGo products. These help
DuckDuckGo validate that the mechanism's logic is working correctly.
Let's note the expected pixels in these shared test cases, so that
each DuckDuckGo product can ensure those requests are being made
correctly.
Further reading: