Skip to content

Conversation

jonathanKingston
Copy link
Contributor

@jonathanKingston jonathanKingston commented Aug 22, 2025

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1206777341262243/task/1210954461043013?focus=true

Description

Adds support for async wrapped values in processAttr features and also function bodies.

For example:

                const configSetting = {
                    type: 'function',
                    functionValue: {
                        type: 'array',
                        value: [],
                        async: true,
                    },
                };
                const result = processAttr(configSetting);

Assists with: https://app.asana.com/1/137249556945/project/1206777341262243/task/1210954461043013?focus=true

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Copy link

netlify bot commented Aug 22, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 7209f69
🔍 Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/68a8660d8167410008b8f846
😎 Deploy Preview https://deploy-preview-1916--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

github-actions bot commented Aug 22, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Aug 22, 2025

[Beta] Generated file diff

Time updated: Fri, 22 Aug 2025 12:52:05 GMT

Android
    - android/autofillPasswordImport.js
  • android/brokerProtection.js
  • android/contentScope.js

File has changed

Apple
    - apple/contentScope.js
  • apple/contentScopeIsolated.js

File has changed

Chrome-mv3
    - chrome-mv3/inject.js

File has changed

Firefox
    - firefox/inject.js

File has changed

Integration
    - integration/contentScope.js

File has changed

Windows
    - windows/contentScope.js

File has changed

@jonathanKingston jonathanKingston marked this pull request as ready for review August 22, 2025 12:51
@jonathanKingston jonathanKingston requested a review from a team as a code owner August 22, 2025 12:51
@jonathanKingston jonathanKingston added this pull request to the merge queue Aug 22, 2025
Merged via the queue into main with commit 6304c5b Aug 22, 2025
24 checks passed
@jonathanKingston jonathanKingston deleted the jkt/functionValues branch August 22, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants