Skip to content

Add in file count check for data.files in canShare #1899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 18, 2025
Merged

Add in file count check for data.files in canShare #1899

merged 3 commits into from
Aug 18, 2025

Conversation

jonathanKingston
Copy link
Contributor

@jonathanKingston jonathanKingston commented Aug 18, 2025 •
edited
Loading

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/72649045549333/task/1211078754350004?focus=true

Description

Allow through sharing with a blank array of files as it breaks the test site (and potentially others) without the need to.

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@netlify Netlify
Copy link

netlify bot commented Aug 18, 2025 •
edited
Loading

✅ Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit da6ed0f
🔍 Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/68a31d85f509cb00087b7cc8
😎 Deploy Preview https://deploy-preview-1899--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 18, 2025 •
edited
Loading

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 18, 2025 •
edited
Loading

[Beta] Generated file diff

Time updated: Mon, 18 Aug 2025 12:52:42 GMT

Android 
    - android/contentScope.js

File has changed

Apple 
    - apple/contentScope.js

File has changed

Integration 
    - integration/contentScope.js

File has changed

Windows 
    - windows/contentScope.js

File has changed

@jonathanKingston jonathanKingston marked this pull request as ready for review August 18, 2025 12:51
@jonathanKingston jonathanKingston requested a review from a team as a code owner August 18, 2025 12:51
@jonathanKingston jonathanKingston added this pull request to the merge queue Aug 18, 2025
Merged via the queue into main with commit 045c51c Aug 18, 2025
23 checks passed
@jonathanKingston jonathanKingston deleted the jkt/share-file-length branch August 18, 2025 20:25
@jonathanKingston jonathanKingston mentioned this pull request Aug 19, 2025
Merged
8 tasks
jonathanKingston added a commit that referenced this pull request Aug 21, 2025
@jonathanKingston
Add in file count check for data.files in canShare (#1899)
7d33f65 
* Add in file count check for data.files in canShare

* Update check and tests

* Lint fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shakyShane shakyShane shakyShane approved these changes

@muodov muodov muodov approved these changes

Assignees

@shakyShane shakyShane

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathanKingston @shakyShane @muodov