adsjs messaging #1883

jonathanKingston · 2025-08-08T17:09:24Z

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/715106103902962/task/1210977763615493?focus=true

Description

Testing Steps

Checklist

Please tick all that apply:

I have tested this change locally
I have tested this change locally in all supported browsers
This change will be visible to users
I have added automated tests that cover this change
I have ensured the change is gated by config
This change was covered by a ship review
This change was covered by a tech design
Any dependent config has been merged

netlify · 2025-08-08T17:09:29Z

✅ Deploy Preview for content-scope-scripts ready!

Name	Link
🔨 Latest commit	`d5dcaf2`
🔍 Latest deploy log	https://app.netlify.com/projects/content-scope-scripts/deploys/68a868202139120008bae549
😎 Deploy Preview	https://deploy-preview-1883--content-scope-scripts.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

github-actions · 2025-08-08T17:09:57Z

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Branch Name: pr-releases/pr-1883
Commit Hash: e8d29ea97990510e829a6b9cae7e6f6081c16546
Last Updated: August 22, 2025 at 12:53:22 PM UTC
Install Command: npm i github:duckduckgo/content-scope-scripts#e8d29ea97990510e829a6b9cae7e6f6081c16546

Please use the above install command to update to the latest version.

github-actions · 2025-08-08T17:10:19Z

[Beta] Generated file diff

Time updated: Fri, 22 Aug 2025 12:53:45 GMT

Android

    - android/autofillPasswordImport.js

android/brokerProtection.js
android/contentScope.js
android/pages/duckplayer/dist/index.js

File has changed

Apple

    - apple/contentScope.js

apple/contentScopeIsolated.js
apple/pages/duckplayer/dist/index.js
apple/pages/duckplayer/index.html
apple/pages/history/dist/index.js
apple/pages/new-tab/dist/index.js
apple/pages/onboarding/dist/index.js
apple/pages/release-notes/dist/index.js
apple/pages/special-error/dist/index.js
apple/pages/special-error/index.html

File has changed

Chrome-mv3

    - chrome-mv3/inject.js

File has changed

Firefox

    - firefox/inject.js

File has changed

Integration

    - integration/contentScope.js

integration/pages/duckplayer/dist/index.js
integration/pages/example/dist/index.js
integration/pages/history/dist/index.js
integration/pages/new-tab/dist/index.js
integration/pages/onboarding/dist/index.js
integration/pages/release-notes/dist/index.js
integration/pages/special-error/dist/index.js

File has changed

Windows

    - windows/contentScope.js

windows/pages/duckplayer/dist/index.js
windows/pages/history/dist/index.js
windows/pages/new-tab/dist/index.js
windows/pages/onboarding/dist/index.js
windows/pages/release-notes/dist/index.js
windows/pages/special-error/dist/index.js
windows/pages/special-error/index.html

File has changed

New Files

    - android/adsjsContentScope.js

❌ File only exists in new changeset

This reverts commit 51f7413.

* Add enum devices debugging * Disable device enumeration remotely * Fix lint * Add frame flexibility * Move to webCompat * Conditional frame matching * Test case * Frame test changes, still not working * Fix up frame testing * Simplify test checks * Remove bundle for debugging * Add injectName conditional matching * Improve comment

* build(deps): bump immutable-json-patch from 6.0.1 to 6.0.2 Bumps [immutable-json-patch](https://github.com/josdejong/immutable-json-patch) from 6.0.1 to 6.0.2. - [Changelog](https://github.com/josdejong/immutable-json-patch/blob/main/CHANGELOG.md) - [Commits](https://github.com/josdejong/immutable-json-patch/commits) --- updated-dependencies: - dependency-name: immutable-json-patch dependency-version: 6.0.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Fix replace state tests * Add failure case if the library behaviour is now reverted --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jonathan Kingston <[email protected]>

#1886) Bumps the eslint group with 1 update: [eslint](https://github.com/eslint/eslint). Updates `eslint` from 9.32.0 to 9.33.0 - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v9.32.0...v9.33.0) --- updated-dependencies: - dependency-name: eslint dependency-version: 9.33.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: eslint ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [@rive-app/canvas-single](https://github.com/rive-app/rive-wasm) from 2.30.4 to 2.31.1. - [Changelog](https://github.com/rive-app/rive-wasm/blob/master/CHANGELOG.md) - [Commits](rive-app/rive-wasm@2.30.4...2.31.1) --- updated-dependencies: - dependency-name: "@rive-app/canvas-single" dependency-version: 2.31.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…1888) The context menu was including fake widgets (like _omnibar-toggleAi for Duck.ai toggle) which caused issues with native app integration. This change: - Updates useContextMenu() to filter out all widgets with IDs starting with '_' - Renames debug widget ID from 'debug' to '_debug' for consistency - Adds integration test to verify only real widgets appear in context menu 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Claude <[email protected]>

* Remove focusRing state and update popup focus styles: - Show rest state by defualt - Show focus state only when input/textarea is selected and empty - Show suggestions state only when suggestions list is open * Make close button clear input and hide suggestions in one click * Adjust padding around X button in SearchForm * Refocus input after clearing search term * Fix spacer height to accommodate largest tab without animation * Use --ntp-surface-tertiary (with correct value from Figma) when using default background and --ntp-surface-background-color when using a custom background * Use dark mode icons in TabSwitcher * Adjust omnibar and tab switcher background when using a custom background * Update ntp-controls-raised-backdrop color variables * Update SearchColorIcon and AiChatColorIcon SVG gradients and colors

* feat: Add Duck.ai icon for RMF, update a couple other icons * fix: example * rm: overflow2 example

…b. (#1894) This matches how SERP behaves

* Refine popup background, outline, and elevation styles * Update CloseSmallIcon

* Refactor variable names and improve type safety in customizer and build scripts Co-authored-by: randerson <[email protected]> * Don't typecast to any --------- Co-authored-by: Cursor Agent <[email protected]>

Bumps [@rive-app/canvas-single](https://github.com/rive-app/rive-wasm) from 2.31.1 to 2.31.2. - [Changelog](https://github.com/rive-app/rive-wasm/blob/master/CHANGELOG.md) - [Commits](rive-app/rive-wasm@2.31.1...2.31.2) --- updated-dependencies: - dependency-name: "@rive-app/canvas-single" dependency-version: 2.31.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [esbuild](https://github.com/evanw/esbuild) from 0.25.8 to 0.25.9. - [Release notes](https://github.com/evanw/esbuild/releases) - [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG.md) - [Commits](evanw/esbuild@v0.25.8...v0.25.9) --- updated-dependencies: - dependency-name: esbuild dependency-version: 0.25.9 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

jonathanKingston · 2025-08-21T08:56:39Z

Bug: Web Share API Unintended Iframe Access

The canShare() function no longer restricts Web Share API usage within iframes. This change, which appears unintended, globally enables Web Share in iframes across all platforms using WebCompat. This could lead to runtime errors or unexpected behavior if the underlying native platform does not support sharing from iframes.

injected/src/features/web-compat.js#L39-L40

Intended as we're supporting iframes in this change. We want to validate it works.

jonathanKingston · 2025-08-22T15:02:50Z

Going to merge so it gets tested, however we'll validate before go-live as we've got full config control here.

jonathanKingston added 4 commits August 8, 2025 10:01

Initial Android adsjs bundle

b13ce17

Rename output script to something more sensible

fb94312

Add inject name

82712bb

lint fix

445ca1b

PoC messaging adsjs

a9d3fb2

jonathanKingston force-pushed the jkt/adsjs-messaging branch from c944c70 to a9d3fb2 Compare August 8, 2025 17:11

jonathanKingston and others added 21 commits August 11, 2025 14:12

Merge remote-tracking branch 'origin/main' into jkt/adsjs-messaging

c0483f1

Removal of ports argument

4688543

Change up wrapping

e227847

Fix up typing

b1cb41b

Enable share on iframes and fix support issues

51f7413

Revert "Enable share on iframes and fix support issues"

742e3c6

This reverts commit 51f7413.

feat: Add Duck.ai icon for RMF, update a couple other RMF icons (#1892)

0776c37

* feat: Add Duck.ai icon for RMF, update a couple other icons * fix: example * rm: overflow2 example

Replace newlines with spaces when switching from Duck.ai to Search ta…

770376d

…b. (#1894) This matches how SERP behaves

NTP: Refine omnibar background, outline, and elevation styles (#1893)

e2d02fc

* Refine popup background, outline, and elevation styles * Update CloseSmallIcon

Fix lint warnings (#1890)

3bc8dfb

* Refactor variable names and improve type safety in customizer and build scripts Co-authored-by: randerson <[email protected]> * Don't typecast to any --------- Co-authored-by: Cursor Agent <[email protected]>

Force search mode when Duck.ai is disabled in Omnibar (#1895)

133d0b2

Add initial ping message

f7febb5

jonathanKingston added 4 commits August 18, 2025 23:26

Merge remote-tracking branch 'origin/main' into jkt/adsjs-messaging

3d7db9a

Fix tests

cf6b3ad

Remove frame limitation

4c59908

Add breakageReporting to bundle

c7c03ad

jonathanKingston marked this pull request as ready for review August 20, 2025 14:23

jonathanKingston requested review from a team as code owners August 20, 2025 14:23

jonathanKingston requested a review from graeme August 20, 2025 14:23

Merge remote-tracking branch 'origin/main' into jkt/adsjs-messaging

0318d11

jonathanKingston force-pushed the jkt/adsjs-messaging branch from c91a031 to 0318d11 Compare August 20, 2025 14:42

This comment was marked as outdated.

Sign in to view

Merge branch 'main' into jkt/adsjs-messaging

401894a

This comment was marked as outdated.

Sign in to view

jonathanKingston added 3 commits August 21, 2025 09:56

Merge branch 'main' into jkt/adsjs-messaging

cbe2331

Merge branch 'main' into jkt/adsjs-messaging

68281e0

Add apiManipulation to the new bundle

d5dcaf2

shakyShane approved these changes Aug 22, 2025

View reviewed changes

jonathanKingston added this pull request to the merge queue Aug 22, 2025

shakyShane approved these changes Aug 22, 2025

View reviewed changes

Merged via the queue into main with commit 722d45c Aug 22, 2025
18 checks passed

jonathanKingston deleted the jkt/adsjs-messaging branch August 22, 2025 15:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

adsjs messaging #1883

adsjs messaging #1883

Uh oh!

jonathanKingston commented Aug 8, 2025

Uh oh!

netlify bot commented Aug 8, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Aug 8, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Aug 8, 2025 •

edited

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

jonathanKingston commented Aug 21, 2025

Bug: Web Share API Unintended Iframe Access

Uh oh!

jonathanKingston commented Aug 22, 2025

Uh oh!

Uh oh!

Uh oh!

adsjs messaging #1883

adsjs messaging #1883

Uh oh!

Conversation

jonathanKingston commented Aug 8, 2025

Description

Testing Steps

Checklist

Uh oh!

netlify bot commented Aug 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for content-scope-scripts ready!

Uh oh!

github-actions bot commented Aug 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Temporary Branch Update

Uh oh!

github-actions bot commented Aug 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

[Beta] Generated file diff

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

jonathanKingston commented Aug 21, 2025

Bug: Web Share API Unintended Iframe Access

Uh oh!

jonathanKingston commented Aug 22, 2025

Uh oh!

Uh oh!

Uh oh!

netlify bot commented Aug 8, 2025 •

edited

Loading

github-actions bot commented Aug 8, 2025 •

edited

Loading

github-actions bot commented Aug 8, 2025 •

edited

Loading