-
Notifications
You must be signed in to change notification settings - Fork 23
Improve playwright tests #852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
77a5cba
to
13fb8e5
Compare
13fb8e5
to
5ff7bfb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR restructures and improves the Playwright test suite by refactoring the test generation logic and enhancing test reliability. The changes focus on better code organization, improved error detection, and performance optimization.
- Refactored test generation from function-based to class-based architecture with the
TestRun
class - Enhanced error detection and assertions with better message handling and reload loop detection
- Optimized test execution by disabling trace collection and increasing worker count
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
playwright/runner.ts | Complete refactoring from function-based to class-based test architecture with improved assertions and error detection |
playwright.config.ts | Disabled trace collection to improve test performance |
Jenkinsfile | Increased worker count and added line reporter for better test output |
Task/Issue URL: https://app.asana.com/1/137249556945/project/1201844467387842/task/1210903143733590?focus=true
https://app.asana.com/1/137249556945/task/1210903143733594
Description:
Several changes to make playwright tests more useful, especially for auto-generated PRs:
I couldn't find a way to mute the stack trace in failure results.
Steps to test this PR: