Skip to content

Improve playwright tests #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Aug 11, 2025
Merged

Improve playwright tests #852

merged 17 commits into from
Aug 11, 2025

Conversation

muodov
Copy link
Member

@muodov muodov commented Aug 4, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/1201844467387842/task/1210903143733590?focus=true
https://app.asana.com/1/137249556945/task/1210903143733594

Description:

Several changes to make playwright tests more useful, especially for auto-generated PRs:

  • detect reload loops
  • more granular message assertions
  • refactor for better readability

I couldn't find a way to mute the stack trace in failure results.

Steps to test this PR:

@muodov muodov changed the base branch from main to review-flag August 6, 2025 07:25
@muodov muodov changed the title Add a flag to mark generated rules requiring review Improve playwright tests Aug 6, 2025
@muodov muodov force-pushed the automated-rule-review branch 2 times, most recently from 77a5cba to 13fb8e5 Compare August 6, 2025 14:03
Base automatically changed from review-flag to main August 6, 2025 14:08
@muodov muodov force-pushed the automated-rule-review branch from 13fb8e5 to 5ff7bfb Compare August 7, 2025 10:10
@muodov muodov marked this pull request as ready for review August 8, 2025 08:13
@muodov muodov requested a review from Copilot August 8, 2025 08:13
@muodov muodov added the tests Add or improve existing tests label Aug 8, 2025
@muodov muodov requested a review from sammacbeth August 8, 2025 08:13
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR restructures and improves the Playwright test suite by refactoring the test generation logic and enhancing test reliability. The changes focus on better code organization, improved error detection, and performance optimization.

  • Refactored test generation from function-based to class-based architecture with the TestRun class
  • Enhanced error detection and assertions with better message handling and reload loop detection
  • Optimized test execution by disabling trace collection and increasing worker count

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
playwright/runner.ts Complete refactoring from function-based to class-based test architecture with improved assertions and error detection
playwright.config.ts Disabled trace collection to improve test performance
Jenkinsfile Increased worker count and added line reporter for better test output

@muodov muodov merged commit 4ab3733 into main Aug 11, 2025
8 checks passed
@muodov muodov deleted the automated-rule-review branch August 11, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants